Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

fix: updated MetricsInstrumentation to implement correct instrumentExecutionResult method #951

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix: updated MetricsInstrumentation to implement correct instrumentExecutionResult method #951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...main/java/graphql/kickstart/autoconfigure/web/servlet/metrics/MetricsInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package graphql.kickstart.autoconfigure.web.servlet.metrics;

import graphql.ExecutionResult;
import graphql.execution.instrumentation.InstrumentationState;
import graphql.execution.instrumentation.parameters.InstrumentationExecutionParameters;
import graphql.execution.instrumentation.tracing.TracingInstrumentation;
import io.micrometer.core.instrument.MeterRegistry;
Expand Down Expand Up @@ -39,6 +40,12 @@ public MetricsInstrumentation(MeterRegistry meterRegistry, boolean tracingEnable
@Override
public CompletableFuture<ExecutionResult> instrumentExecutionResult(
ExecutionResult executionResult, InstrumentationExecutionParameters parameters) {
return this.instrumentExecutionResult(executionResult, parameters, null);
}

@Override
public CompletableFuture<ExecutionResult> instrumentExecutionResult(
ExecutionResult executionResult, InstrumentationExecutionParameters parameters, InstrumentationState rawState) {

if (executionResult.getExtensions() != null
&& executionResult.getExtensions().containsKey(TRACING)) {
Expand Down