Skip to content

Upgrade to combine 4.x.y #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

DoumanAsh
Copy link

Subj
Most notable change is combine::parser doesn't accept functions that return combine::ParseResult so you have to convert it each time.
Probably could just write own version that accepts combine::ParseResult to avoid conversion

@tailhook
Copy link
Collaborator

Hi! Thanks for the PR. And sorry for late reply. There are two issues with the PR.

  1. unexpected_format should probably be replaced by unexpected_static_message instead where message in static (pretty minor)
  2. Instead of parse_stream(input).into(), I think we should use -> impl Parser<..> return everywhere (there was no -> impl at the point this was originally implemented, this is why it's not used). The change should be pretty mechanical, although we need to use opaque! macro at some place where nested nodes are used.

@DoumanAsh
Copy link
Author

Got it
Although it doesn't seem to me that replacing parser functions with just returning impl Parser is all that simple to be honest.
But then again I'm not all that familiar with combine

@LegNeato
Copy link
Member

This has been superceded.

@LegNeato LegNeato closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants