-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update LICENSE and remove license header from source files #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
/* @noflow */ | ||
// @noflow | ||
|
||
'use strict'; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,4 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow strict | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I looked at the source code for a couple of other projects under LF (Node.js, ESLint, esprima) and they just just have LICENSE at the root of the project and no license headers inside the source code. Those headers add some inconvenience in the development process e.g. new contributors forget to add them, old PRs contains an old version of the license text, it's harder to diff and revert old commits, etc. Plus they effectively double up the size of NPM package:
VS
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I mad mistake during measurement, in reality, it was around ~100 kB difference unpacked. |
||
// @flow strict | ||
|
||
import { printError } from './printError'; | ||
import { type ASTNode } from '../language/ast'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from
graphql-faq
repository: https://github.com/graphql/faq/blob/954d07c108634ebed1414b3380c830498bb0bbb6/LICENSE#L3