grpc: fix bug causing an extra Read if a compressed message is the same size as the limit #8178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8178 +/- ##
==========================================
- Coverage 82.11% 82.04% -0.07%
==========================================
Files 410 410
Lines 40251 40251
==========================================
- Hits 33051 33023 -28
- Misses 5844 5862 +18
- Partials 1356 1366 +10
🚀 New features to boost your workflow:
|
|
Talked offline, it would be much simpler to restrict the max message size to |
|
Updated to use an io.LimitReader again. |
arjan-bal
approved these changes
Mar 18, 2025
rpc_util_test.go
Outdated
| case <-ctx.Done(): | ||
| t.Fatalf("Timed out waiting for call to compressor") | ||
| } | ||
| ctx, cancel = context.WithTimeout(ctx, 10*time.Millisecond) |
There was a problem hiding this comment.
nit: Should we define a defaultTestShortTimeout and use it here to avoid having tests using different wait durations later?
rpc_util_test.go
Outdated
| return m, nil | ||
| } | ||
|
|
||
| func (m *mockCompressor) Read(p []byte) (int, error) { |
There was a problem hiding this comment.
nit: Vet is mentioning that the variable name can be dropped.
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Mar 18, 2025
…me size as the limit (grpc#8178)
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Mar 24, 2025
…me size as the limit (grpc#8178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8171
This is an alternate fix to the above issue as mentioned in #8172.
I'll add a test case that ensures Read is not called beyond io.EOF. But it looks like there might be some other problems with the tests in
rpc_util_test.go, as several test cases are not setting the decompressor fielddc, and I want to look at that more closely, too.cc @jhump
RELEASE NOTES: