Skip to content

Update lrs_stream.go fix use of wrong err #8224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Conversation

alingse
Copy link
Contributor

@alingse alingse commented Apr 4, 2025

the origin err has been checked in line 233.

it is nil now, and after check CheckInvalid() != nil,

here should use the check err

RELEASE NOTES:

  • xds: Fix reported error string when LRS load reporting interval is invalid.

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.02%. Comparing base (51d6a43) to head (c808c95).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
xds/internal/xdsclient/transport/lrs/lrs_stream.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8224      +/-   ##
==========================================
- Coverage   82.18%   82.02%   -0.16%     
==========================================
  Files         410      412       +2     
  Lines       40236    40491     +255     
==========================================
+ Hits        33066    33214     +148     
- Misses       5824     5900      +76     
- Partials     1346     1377      +31     
Files with missing lines Coverage Δ
xds/internal/xdsclient/transport/lrs/lrs_stream.go 70.55% <66.66%> (ø)

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal added this to the 1.73 Release milestone Apr 8, 2025
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Adding a second reviewer.

@easwars easwars merged commit f0676ea into grpc:master Apr 14, 2025
15 checks passed
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants