-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Android: Clean up lint warnings and other warnings to get build success #12143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@ejona86 @shivaspeaks Can you please review. |
@Sangamesh1997 Can you provide the build error log that you are fixing with this PR? In the failing build.log of PR #12040 I don't see any errors about @TargetApi for example. |
@kannanjgithub In the build log of PR #12040 , I observed that the only visible lint error was OldTargetApi. However, when I ran the lint check locally in (lint report.html), it also flagged other warnings like InlineApi, ObseleteSdkInt and NewApi, as mentioned by Eric earlier. So in this PR, I've fixed all these together to ensure build passes cleanly and is future-proof. |
@Sangamesh1997 can you share that lint report.html? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we working on silencing? I thought the discussion happened to upgrade and fix in the #12040 (comment)
@shivaspeaks I have addressed and cleared all the lint warnings in #12143, which resolves the issue tracked in #6868. |
Fixes : #6868 #12142