Use go-secure-stdlib's RSA key generator backed by a DRBG #29020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
There was a problem hiding this comment.
There's a reference to rsa.GenerateKey within sdk/helper/certutil/helpers.go line 371 that was missed.
Beyond that and the go.mod conflict 👍
stevendpclark
previously approved these changes
Nov 28, 2024
fairclothjm
previously approved these changes
Dec 5, 2024
stevendpclark
approved these changes
Dec 5, 2024
fairclothjm
approved these changes
Dec 5, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Use DRBG based RSA key generation everywhere * switch to the conditional generator * Use DRBG based RSA key generation everywhere * switch to the conditional generator * Add an ENV var to disable the DRBG in a pinch * update go.mod * Use DRBG based RSA key generation everywhere * switch to the conditional generator * Add an ENV var to disable the DRBG in a pinch * Use DRBG based RSA key generation everywhere * update go.mod * fix import * Remove rsa2 alias, remove test code * move cryptoutil/rsa.go to sdk * move imports too * remove makefile change * rsa2->rsa * more rsa2->rsa, remove test code * fix some overzelous search/replace * Update to a real tag * changelog * copyright * work around copyright check * work around copyright check pt2 * bunch of dupe imports * missing import * wrong license * fix go.mod conflict * missed a spot * dupe import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the random source is not crypto/rand.Reader, use a secure deterministic
random bit generator seeded by the random source to generate RSA keys,
rather than the source directly. This massively improves performance for
RSA key generation if the source is a slow RNG, as can be found in many
HSMs.
This fixes customer issues resulting in timeouts as key generation can take several minutes on some HSMs, needing to pull thousands of candidate numbers for primes. In particular:
https://hashicorp.atlassian.net/browse/VAULT-21911 and https://hashicorp.atlassian.net/browse/VAULT-31473
This feature is on by default but can be overridden by setting VAULT_DISABLE_RSA_DRBG
to true.
https://hashicorp.atlassian.net/browse/VAULT-32705
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.