CLI: add an option for renew command fail on non-fulfillable request… #29060
Conversation
|
|
saiaunghlyanhtet
requested review from
brewgator
and removed request for
a team
saiaunghlyanhtet
force-pushed
the
feature/valut-token-renew-fail
branch
from
6944989 to
0bfa0c1
Compare
There was a problem hiding this comment.
Hi @saiaunghlyanhtet, thank you for the contribution! I'm currently gathering some opinions regarding this CLI-only implementation, will get back to you end of next week at the latest on that.
saiaunghlyanhtet
force-pushed
the
feature/valut-token-renew-fail
branch
2 times, most recently
from
f9a4096 to
06a493c
Compare
saiaunghlyanhtet
force-pushed
the
feature/valut-token-renew-fail
branch
from
06a493c to
94a436b
Compare
changelog/29060.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
| CLI: adds an optional flag (--fail-if-not-fullfilled) to the renew command, which lets the renew command fail on unfulfillable requests and allows command chaining to allow further executions. | |||
There was a problem hiding this comment.
there's one remaining typo in this fulfilled. Also in the PR title and description.
| @@ -53,3 +59,7 @@ flags](/vault/docs/commands) included on all commands. | |||
| Vault will not honor this request for periodic tokens. If not supplied, Vault will use | |||
| the default TTL. This is specified as a numeric string with suffix like "30s" | |||
| or "5m". This is aliased as "-i". | |||
|
|
|||
| - `--fail-if-not-fulfilled` - Allow command chaining after renew request fail. | |||
There was a problem hiding this comment.
I believe this should match the command Usage field that's displayed in vault token renew --help. This seems to be a consistent pattern across options for many (all?) commands. I'd suggest setting both Usage and these docs to an initial short description of what the flag does, like your Fail if the requested TTL increment cannot be fully fulfilled. and then move on with these additional details of how it can be used.
Also a nit: the current text seems a bit repetitive by mentioning that the flag allows command chaining twice.
saiaunghlyanhtet
changed the title
saiaunghlyanhtet
force-pushed
the
feature/valut-token-renew-fail
branch
from
94a436b to
028f058
Compare
saiaunghlyanhtet
force-pushed
the
feature/valut-token-renew-fail
branch
from
028f058 to
5a7c32c
Compare
Resolved conflict. |
| - `--fail-if-not-fulfilled` - Fail if the requested TTL increment cannot be fully fulfilled. | ||
| Vault will allow token renewal request completion with capped duration even if renew request fails. | ||
| And Vault will also allow command chaining after renew command. |
There was a problem hiding this comment.
| - `--fail-if-not-fulfilled` - Fail if the requested TTL increment cannot be fully fulfilled. | |
| Vault will allow token renewal request completion with capped duration even if renew request fails. | |
| And Vault will also allow command chaining after renew command. | |
| - `--fail-if-not-fulfilled` - Fail if the requested TTL increment cannot be | |
| fully fulfilled. Vault allows command chaining and token renewal request | |
| completion with capped duration even if renew request fails. |
Style correction: write in active voice
There was a problem hiding this comment.
Made changes as requested.
… to allow command chaining Signed-off-by: saiaunghlyanhtet <[email protected]>
saiaunghlyanhtet
force-pushed
the
feature/valut-token-renew-fail
branch
from
5a7c32c to
f111f22
Compare
Description
What does this PR do?
This pull request adds an optional flag (--fail-if-not-fulfilled) to the renew command, which lets the renew command fail on unfulfillable requests and allows command chaining to allow further executions.
Related Issue: #28710