-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Add UI support name constraints #29263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build Results: |
CI Results: |
get showHelpText() { | ||
return this.args.showHelpText === false ? false : true; | ||
} | ||
get subText() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed as this was unused! 🧹 @subText
is passed to FormFieldLabel
in some situations, but there were no instances of passing subtext directly to the <FormField>
component (we typically pass it in the attribute options object)
@@ -0,0 +1,3 @@ | |||
```release-note:improvement | |||
ui: Add support for the name constraints extension to be fully specified when creating root and intermediate CA certificates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: maybe add the word PKI somewhere in the description. Those familiar with it I'm sure understand that CA certificates indicate PKI, but if I were to cntrl+f the changelog I might type PKI
to see if something in that area had changed. Something like ui/pki: ...
or within the description itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we want to start changing the changelog format ui/:item
then that's something we should talk about! I don't think we've done that here, and a one off feels a little random
toggleSigningOptions: '[data-test-toggle-group="Signing options"]', | ||
toggleSANOptions: '[data-test-toggle-group="Subject Alternative Name (SAN) Options"]', | ||
toggleAdditionalFields: '[data-test-toggle-group="Additional subject fields"]', | ||
toggleGroup: (group) => `[data-test-toggle-group="${group}"]`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: there is a toggleGroup in the general-selectors.ts file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Since we don't import general selectors here, I was just following the existing pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of non-blocking comments. If you want to modify, hit me up again and I'll give another green check.
Thanks for those callouts! I'll amend in a follow on as I don't want to bother crypto with a re-review |
Description
Adds UI support for params added by #29245. Params are nested inside the
Name constraints
toggle when signing an intermediateTODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.