Skip to content

Add UI support name constraints #29263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 2, 2025
Merged

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Dec 26, 2024

Description

Adds UI support for params added by #29245. Params are nested inside the Name constraints toggle when signing an intermediate

Screenshot 2024-12-23 at 5 29 32 PM
Screenshot 2024-12-26 at 3 24 29 PM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo requested a review from a team as a code owner December 26, 2024 20:27
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 26, 2024
@hellobontempo hellobontempo added this to the 1.19.0-rc milestone Dec 26, 2024
Copy link

github-actions bot commented Dec 26, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Dec 26, 2024

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo requested a review from a team as a code owner December 26, 2024 21:06
@hellobontempo hellobontempo requested a review from a team as a code owner December 26, 2024 21:28
@hellobontempo hellobontempo requested a review from lursu December 26, 2024 21:28
get showHelpText() {
return this.args.showHelpText === false ? false : true;
}
get subText() {
Copy link
Contributor Author

@hellobontempo hellobontempo Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed as this was unused! 🧹 @subText is passed to FormFieldLabel in some situations, but there were no instances of passing subtext directly to the <FormField> component (we typically pass it in the attribute options object)

@@ -0,0 +1,3 @@
```release-note:improvement
ui: Add support for the name constraints extension to be fully specified when creating root and intermediate CA certificates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: maybe add the word PKI somewhere in the description. Those familiar with it I'm sure understand that CA certificates indicate PKI, but if I were to cntrl+f the changelog I might type PKI to see if something in that area had changed. Something like ui/pki: ... or within the description itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we want to start changing the changelog format ui/:item then that's something we should talk about! I don't think we've done that here, and a one off feels a little random

toggleSigningOptions: '[data-test-toggle-group="Signing options"]',
toggleSANOptions: '[data-test-toggle-group="Subject Alternative Name (SAN) Options"]',
toggleAdditionalFields: '[data-test-toggle-group="Additional subject fields"]',
toggleGroup: (group) => `[data-test-toggle-group="${group}"]`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: there is a toggleGroup in the general-selectors.ts file.

Copy link
Contributor Author

@hellobontempo hellobontempo Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since we don't import general selectors here, I was just following the existing pattern

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of non-blocking comments. If you want to modify, hit me up again and I'll give another green check.

@hellobontempo
Copy link
Contributor Author

A couple of non-blocking comments. If you want to modify, hit me up again and I'll give another green check.

Thanks for those callouts! I'll amend in a follow on as I don't want to bother crypto with a re-review

@hellobontempo hellobontempo merged commit 91d88c3 into main Jan 2, 2025
90 of 92 checks passed
@hellobontempo hellobontempo deleted the add-ui-support-name-constraints branch January 2, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants