-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Vault 34905 support register ce plugin with extracted artifact #30673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault 34905 support register ce plugin with extracted artifact #30673
Conversation
CI Results: |
Build Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work and test coverages @helenfufu!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @helenfufu! I did some testing with vault-plugin-database-snowflake to test the backwards compatibility. I just left one question on the pgp key.
|
||
// hashiCorpPGPPubKey is HashiCorp's PGP public key at https://www.hashicorp.com/.well-known/pgp-key.txt. | ||
// This key is used to verify the authenticity of HashiCorp plugins. | ||
const hashiCorpPGPPubKey = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should vault fetch this from the well-known endpoint and cache it? What happens if this ever needs to change? Ideally that would not happen, but it has happened in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed up on Slack about this question after chatting with Thy.
Thanks btw for testing with the Snowflake plugin!
* apply oss changes from hashicorp/vault-enterprise#8071 * handle oss file deletions * go mod tidy * add changelog
* apply oss changes from hashicorp/vault-enterprise#8071 * handle oss file deletions * go mod tidy * add changelog
Description
This PR contains the subset of CE changes from https://github.com/hashicorp/vault-enterprise/pull/8071. It primarily refactors variable, function, and file organization such that artifact verification, and registration functionality is shared across Vault CE and ENT going forward. This artifact functionality was previously ENT-only.
PR description copied below:
Ticket: VAULT-34905
Local Testing
Test results: [link]
Vault CE
Auth/secrets
vault-plugin-secrets-kv_0.18.0_darwin_arm64.zip
artifact built off https://github.com/hashicorp/vault-plugin-release/pull/55: https://github.com/hashicorp/vault-plugin-release/actions/runs/14366149960)Database
vault-plugin-database-oracle_0.10.2_linux_amd64.zip
artifact built off https://github.com/hashicorp/vault-plugin-release/compare/vault-34905-test-oracle-ce-artifact?expand=1: https://github.com/hashicorp/vault-plugin-release/actions/runs/15078913234)TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.