This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Use functions exported from GHC.HsToCore.Docs #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
force-pushed
the
wip/haddock-hstocore
branch
from
f0b1198 to
4424031
Compare
|
@harpocrates thoughts on this? |
wz1000
force-pushed
the
wip/haddock-hstocore
branch
from
4424031 to
45add0d
Compare
|
Thanks @wz1000! This looks like a nice improvement to me. :) |
|
Yes, thank you! Did you make sure the deleted code really matches the Haddock one (in other words - has there been any accidental divergence?). If so, LGTM. 👍 |
|
I had quickly gone through it earlier, but I just went through it line by line. I found one missing case, one missing bang pattern and one missing comment. I've updated the ghc MR with these now. |
|
Thanks! That’s my only concern so, all good on the Haddock side - merge with the GHC MR I guess.
… On Jun 23, 2020, at 11:32 AM, wz1000 ***@***.***> wrote:
I had quickly gone through it earlier, but I just went through it line by line. I found one missing case, one missing bang pattern and one missing comment. I've updated the ghc MR with these now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1204 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACSEOANI52GVGETU2V4AHJ3RYDDJVANCNFSM4N2ABIAA>.
|
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
May 17, 2024
Use functions exported from GHC.HsToCore.Docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3475
This seems like low hanging fruit from #906 that should be easy to adopt, and a clear win since it reduces duplication and synchronization bugs like https://gitlab.haskell.org/ghc/ghc/issues/18241.
/cc @sjakobi