Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Add dangling changes from branches ghc-8.6 and ghc-8.8 #1243

Merged
merged 6 commits into from
Dec 8, 2020

Conversation

Lysxia
Copy link
Contributor

@Lysxia Lysxia commented Oct 30, 2020

Fixes #1219

mattaudesse and others added 6 commits October 30, 2020 10:45
Note: I noticed some overlap with #1112 from @wygulmage and #1081 from
@parsonsmatt after creating these proposed changes - mea culpa for not
looking at the open PRs sooner.
The current formatting of the missing link destination does not really
help user to understand the reasons of the missing link.

To address this, I've changed the formatting in two ways:

- the missing link symbol name is now fully qualified. This way you
immediately know which haskell module cannot be linked. It is then easier
to understand why this module does not have documentation (hidden module
or broken documentation).
- one line per missing link, that's more readable now that symbol name
can be longer due to qualification.

For example, before haddock was listing missing symbol such as:

```
could not find link destinations for:
  Word8 Word16 mapMaybe
```

Now it is listed as:

```
could not find link destinations for:
  - Data.Word.Word8
  - Data.Word.Word16
  - Data.Maybe.mapMaybe
```
This argument can be used multiples time. A missing link to a symbol
listed by `--ignore-link-symbol` won't trigger "missing link" warning.
Copy link
Member

@alexbiehl alexbiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing the busywork!

@alexbiehl alexbiehl merged commit 7240b69 into haskell:ghc-8.10 Dec 8, 2020
@alexbiehl
Copy link
Member

Ah, dang, I squashed 🤦

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dangling changes in ghc-8.6 and ghc-8.8 branches
6 participants