Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Enable two warnings #1272

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Enable two warnings #1272

merged 1 commit into from
Dec 20, 2020

Conversation

tomjaguarpaw
Copy link
Member

because they will be soon be added to -Wall.

See https://gitlab.haskell.org/ghc/ghc/-/issues/15656

Last time I attempted to get this into ghc-head I didn't follow the usual procedure and it caused problems. This time, by way of extra caution, I explain how I am explicitly following @bgamari's instructions:

  1. push your branch to a wip/ branch on https://gitlab.haskell.org/ghc/haddock (and your GitHub fork, if you want)

    ✔ It is at https://gitlab.haskell.org/ghc/haddock/-/tree/wip/tomjaguarpaw1-haddock-warnings

  2. open a GHC merge request bumping the haddock submodule.

    ✔ It is at https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4614

  3. wait for the merge request to pass CI and get approval

    ✔ It has passed CI and @goldfirere has approved

  4. push your haddock changes to GitHub (if you haven't already) and request that they be merged to the ghc-head branch

    ✔ This is that request

  5. wait for the GitHub MR to be merged; after it's merged queue up the GHC MR for merge

    ⌛ Waiting for merge of this PR

@monoidal monoidal merged commit beafcac into haskell:ghc-head Dec 20, 2020
@tomjaguarpaw tomjaguarpaw deleted the warnings branch December 20, 2020 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants