This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Enable two warnings #1272
Merged
Enable two warnings #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because they will be soon be added to -Wall.
See https://gitlab.haskell.org/ghc/ghc/-/issues/15656
Last time I attempted to get this into ghc-head I didn't follow the usual procedure and it caused problems. This time, by way of extra caution, I explain how I am explicitly following @bgamari's instructions:
push your branch to a wip/ branch on https://gitlab.haskell.org/ghc/haddock (and your GitHub fork, if you want)
✔ It is at https://gitlab.haskell.org/ghc/haddock/-/tree/wip/tomjaguarpaw1-haddock-warnings
open a GHC merge request bumping the haddock submodule.
✔ It is at https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4614
wait for the merge request to pass CI and get approval
✔ It has passed CI and @goldfirere has approved
push your haddock changes to GitHub (if you haven't already) and request that they be merged to the ghc-head branch
✔ This is that request
wait for the GitHub MR to be merged; after it's merged queue up the GHC MR for merge
⌛ Waiting for merge of this PR