This repository was archived by the owner on Aug 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 236
Add better support for default signatures in class definitions #822
Closed
Closed
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2cf2953
Add better support for default signatures in class definitions
blmage 6ab9931
Clean up and comment the changes for default signatures support
blmage 9029b8a
Remove unnecessary import
blmage 79bf3ea
Fix default signatures support for reexports
blmage fefcf88
Add new test for default signatures
blmage 583bcff
Merge branch 'class-default-sigs' of https://github.com/mac-adder/had…
RyanGlScott 50a37cc
Post-rebase sludge
RyanGlScott ec0a8ba
Cleanup
RyanGlScott b01e796
Add better support for default signatures in class definitions
blmage 7c8a6bb
Clean up and comment the changes for default signatures support
blmage 657dc17
Remove unnecessary import
blmage ccb8d01
Fix default signatures support for reexports
blmage 02a0b1e
Add new test for default signatures
blmage 76fb092
Post-rebase sludge
RyanGlScott a976c95
Cleanup
RyanGlScott d2fe72d
Merge branch 'class-default-sigs-rebased' into class-default-sigs
harpocrates ddc115e
Manually prod default-sig subdocs into ExportDecl
harpocrates File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,178 @@ | ||
| <html xmlns="http://www.w3.org/1999/xhtml" | ||
| ><head | ||
| ><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" | ||
| /><title | ||
| >DefaultSignatures</title | ||
| ><link href="#" rel="stylesheet" type="text/css" title="Ocean" | ||
| /><link rel="stylesheet" type="text/css" href="#" | ||
| /><script src="haddock-bundle.min.js" async="async" type="text/javascript" | ||
| ></script | ||
| ><script src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.0/MathJax.js?config=TeX-AMS-MML_HTMLorMML" type="text/javascript" | ||
| ></script | ||
| ></head | ||
| ><body | ||
| ><div id="package-header" | ||
| ><ul class="links" id="page-menu" | ||
| ><li | ||
| ><a href="#" | ||
| >Contents</a | ||
| ></li | ||
| ><li | ||
| ><a href="#" | ||
| >Index</a | ||
| ></li | ||
| ></ul | ||
| ><p class="caption empty" | ||
| ></p | ||
| ></div | ||
| ><div id="content" | ||
| ><div id="module-header" | ||
| ><table class="info" | ||
| ><tr | ||
| ><th | ||
| >Safe Haskell</th | ||
| ><td | ||
| >Safe</td | ||
| ></tr | ||
| ></table | ||
| ><p class="caption" | ||
| >DefaultSignatures</p | ||
| ></div | ||
| ><div id="synopsis" | ||
| ><details id="syn" | ||
| ><summary | ||
| >Synopsis</summary | ||
| ><ul class="details-toggle" data-details-id="syn" | ||
| ><li class="src short" | ||
| ><span class="keyword" | ||
| >class</span | ||
| > <a href="#" | ||
| >Foo</a | ||
| > a <span class="keyword" | ||
| >where</span | ||
| ><ul class="subs" | ||
| ><li | ||
| ><a href="#" | ||
| >bar</a | ||
| >, <a href="#" | ||
| >baz</a | ||
| > :: a -> <a href="#" title="Data.String" | ||
| >String</a | ||
| ></li | ||
| ><li | ||
| ><a href="#" | ||
| >baz'</a | ||
| > :: <a href="#" title="Data.String" | ||
| >String</a | ||
| > -> a</li | ||
| ></ul | ||
| ></li | ||
| ></ul | ||
| ></details | ||
| ></div | ||
| ><div id="interface" | ||
| ><h1 | ||
| >Documentation</h1 | ||
| ><div class="top" | ||
| ><p class="src" | ||
| ><span class="keyword" | ||
| >class</span | ||
| > <a id="t:Foo" class="def" | ||
| >Foo</a | ||
| > a <span class="keyword" | ||
| >where</span | ||
| > <a href="#" class="selflink" | ||
| >#</a | ||
| ></p | ||
| ><div class="doc" | ||
| ><p | ||
| >Documentation for Foo.</p | ||
| ></div | ||
| ><div class="subs minimal" | ||
| ><p class="caption" | ||
| >Minimal complete definition</p | ||
| ><p class="src" | ||
| ><a href="#" title="DefaultSignatures" | ||
| >baz</a | ||
| ></p | ||
| ></div | ||
| ><div class="subs methods" | ||
| ><p class="caption" | ||
| >Methods</p | ||
| ><p class="src" | ||
| ><a id="v:bar" class="def" | ||
| >bar</a | ||
| > :: a -> <a href="#" title="Data.String" | ||
| >String</a | ||
| > <a href="#" class="selflink" | ||
| >#</a | ||
| ></p | ||
| ><div class="doc" | ||
| ><p | ||
| >Documentation for bar and baz.</p | ||
| ></div | ||
| > <div class="subs default" | ||
| ><p class="caption" | ||
| ></p | ||
| ><p class="src" | ||
| ><span class="keyword" | ||
| >default</span | ||
| > <a id="v:bar" class="def" | ||
| >bar</a | ||
| > :: <a href="#" title="Text.Show" | ||
| >Show</a | ||
| > a => a -> <a href="#" title="Data.String" | ||
| >String</a | ||
| > <a href="#" class="selflink" | ||
| >#</a | ||
| ></p | ||
| ></div | ||
| ><p class="src" | ||
| ><a id="v:baz" class="def" | ||
| >baz</a | ||
| > :: a -> <a href="#" title="Data.String" | ||
| >String</a | ||
| > <a href="#" class="selflink" | ||
| >#</a | ||
| ></p | ||
| ><div class="doc" | ||
| ><p | ||
| >Documentation for bar and baz.</p | ||
| ></div | ||
| ><p class="src" | ||
| ><a id="v:baz-39-" class="def" | ||
| >baz'</a | ||
| > :: <a href="#" title="Data.String" | ||
| >String</a | ||
| > -> a <a href="#" class="selflink" | ||
| >#</a | ||
| ></p | ||
| ><div class="doc" | ||
| ><p | ||
| >Documentation for baz'.</p | ||
| ></div | ||
| > <div class="subs default" | ||
| ><p class="caption" | ||
| ></p | ||
| ><p class="src" | ||
| ><span class="keyword" | ||
| >default</span | ||
| > <a id="v:baz-39-" class="def" | ||
| >baz'</a | ||
| > :: <a href="#" title="Text.Read" | ||
| >Read</a | ||
| > a => <a href="#" title="Data.String" | ||
| >String</a | ||
| > -> a <a href="#" class="selflink" | ||
| >#</a | ||
| ></p | ||
| ></div | ||
| ></div | ||
| ></div | ||
| ></div | ||
| ></div | ||
| ><div id="footer" | ||
| ></div | ||
| ></body | ||
| ></html | ||
| > |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit suspicious. That said, I think the smell is coming more from the fact that
deriveUniqueexists... and I don't see another easy workaround.