Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Avoid legacy warning #1273

Merged
merged 1 commit into from
May 31, 2019
Merged

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented May 30, 2019

closes #1201

@fendor fendor requested review from Anrock and samuelpilz May 30, 2019 20:01
@fendor fendor merged commit 19317e5 into haskell:master May 31, 2019
@@ -247,7 +247,7 @@ installCabal = do
-- install `cabal-install` if not already installed
when (isNothing cabalExe) $
execStackShake_ ["install", "cabal-install"]
execCabal_ ["update"]
execCabal_ ["v1-update"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had this before, and it broke installs for people using earlier versions of cabal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably true, but we demand that the cabal version is at least 2.4.1.0. this is checked before that.

@alanz alanz added this to the 2019-05 milestone Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 style warnings during stack ./install.hs
3 participants