vscode dependency -> @types/vscode #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the vscode package is deprecated: https://www.npmjs.com/package/vscode
Also correct output generation
lukel97
approved these changes
Aug 26, 2020
| @@ -1,15 +1,17 @@ | |||
| { pkgs ? import <nixpkgs> {} }: | |||
| with pkgs; | |||
| pkgs.mkYarnPackage { | |||
| name = "vscode-haskell"; | |||
There was a problem hiding this comment.
Ah does this need to match up with the package name inside package.json?
There was a problem hiding this comment.
I don't think it's important actually. (of course line 14 needs to be correct either way)
|
Hmm ci is failing, will take a look |
vscode is no longer a devDependency, since it has been split into types and a test package, see https://code.visualstudio.com/updates/v1_36#_splitting-vscode-package-into-typesvscode-and-vscodetest This is a leftover from using the testing stuff in it, which we don't use anyway
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the vscode package is deprecated: https://www.npmjs.com/package/vscode
Tested by building with nix (after running 'yarn import')