forked from open-telemetry/opentelemetry-collector-contrib
-
Notifications
You must be signed in to change notification settings - Fork 1
Implement dimension settings using MetricDeclarations #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging @mxiamxia |
This was referenced Oct 16, 2020
mxiamxia
reviewed
Oct 28, 2020
mxiamxia
reviewed
Oct 28, 2020
#1446) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.17 to 1.35.19. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.17...v1.35.19) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
8936787
to
6a0c283
Compare
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.17 to 1.35.20. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.17...v1.35.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.32.0 to 1.33.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.32.0...v1.33.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.32.0 to 1.33.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.32.0...v1.33.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/golang/protobuf/releases) - [Commits](golang/protobuf@v1.4.2...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [go.opencensus.io](https://github.com/census-instrumentation/opencensus-go) from 0.22.4 to 0.22.5. - [Release notes](https://github.com/census-instrumentation/opencensus-go/releases) - [Commits](census-instrumentation/opencensus-go@v0.22.4...v0.22.5) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1457) Bumps [go.opencensus.io](https://github.com/census-instrumentation/opencensus-go) from 0.22.4 to 0.22.5. - [Release notes](https://github.com/census-instrumentation/opencensus-go/releases) - [Commits](census-instrumentation/opencensus-go@v0.22.4...v0.22.5) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.11.1 to 1.11.2. - [Release notes](https://github.com/klauspost/compress/releases) - [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml) - [Commits](klauspost/compress@v1.11.1...v1.11.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.19.2 to 0.19.3. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.19.2...v0.19.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [gopkg.in/DataDog/dd-trace-go.v1](https://github.com/DataDog/dd-trace-go) from 1.26.0 to 1.27.1. - [Release notes](https://github.com/DataDog/dd-trace-go/releases) - [Commits](DataDog/dd-trace-go@v1.26.0...v1.27.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.34.9 to 1.35.20. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.34.9...v1.35.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.32.0 to 0.34.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.32.0...v0.34.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.17 to 1.35.20. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.17...v1.35.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.17 to 1.35.20. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.17...v1.35.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…or (#1472) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.2 to 1.35.20. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.2...v1.35.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1452) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.19 to 1.35.20. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.19...v1.35.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Bogdan Drutu <[email protected]>
…1487) Signed-off-by: Bogdan Drutu <[email protected]>
* Move test as per CR comments * Fix getting cached value * Remove unneeded dependencies and config sections
Fix an error for the config file part.
Signed-off-by: Bogdan Drutu <[email protected]>
* initial commit of ecs translation * reverted trace ID change * added unit tests * addressed comments and unit test issues * fixed breaking API changes
Resolves: open-telemetry/opentelemetry-collector#1841 This uses the new Span Status Code/DeprecatedCode from core repo. Changes to Span Status are described in more details in this core PR: open-telemetry/opentelemetry-collector#2031
* Fix the race condition issue for xray receiver * Fix the race condition issue for xray receiver * Fix the race condition issue for xray receiver * Fix the race condition issue for xray receiver
mxiamxia
reviewed
Nov 5, 2020
Adds resource detection of hostname and host information when running on a bare host. **Link to tracking Issue:** #1292 **Testing:** Unit tests were added; processor was tested on a Linux and macOS host. **Documentation:** - Updated README with the information gathered by this detector - Updated examples
mxiamxia
approved these changes
Nov 5, 2020
5d8cbbd
to
a736ad0
Compare
* Bump github.com/golangci/golangci-lint from 1.31.0 to 1.32.2 Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.31.0 to 1.32.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.31.0...v1.32.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump gopsutil to 3.20.10 instead Signed-off-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <[email protected]>
* Pass around config * Attach logger to Config * Add check for unhandled data type * Format code
* Implement dimension dedup logic when adding rolledup dimensions * Remove duplicated dimensions in metric declaration
…tCwMeasurementEqual for tests
a736ad0
to
e6c1ff3
Compare
Opened PR to upstream: open-telemetry#1503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the necessary functionality to perform dimension setting for exported metrics, as required by the ECS team. Specifically, this PR accomplishes the following:
metric_declarations
attribute in the config file which specifies the rules used for dimension setting.metric_name_selectors
for that rule. If no selectors are defined, this rule is dropped as invalid._aws
field) using the dimensions specified by the metric declaration rules. If the metric does not match any rules or specified dimensions, drop the metric (i.e. don't include the_aws
field). If any specified dimensions exceed 10 elements, drop them as CW does not support them.Additionally, the following sanity checks for user-defined metric declarations are implemented:
['dim1', 'dim2', 'dim1']
->['dim1', 'dim2']
)[['dim1', 'dim2'], ['dim2', 'dim1']]
->[['dim1', 'dim2']]
)In all 3 cases, we output a warning message informing the user of the dropped elements. More information about this dedup logic can be found in #6.
Testing
This code change has been tested with unit tests and in a sample environment using an NGINX server on EKS. Given the following config:
The exported CW logs look like this:
1 matching rule (w/ 1 unmatched dimension):
go_goroutines
:1 matching rule (w/ dedup):
go_memstats_alloc_bytes
:2 matching rules w/ dedup):
No matching rule:
Documentation
The documentation in the README for the awsemfexporter is also updated to include this new API change.