-
Notifications
You must be signed in to change notification settings - Fork 6
Add a script to populate the array of available versions (per project) #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: marko-bekhta <[email protected]>
exit 1 | ||
fi | ||
|
||
pushd ${WORKSPACE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this points to a directory that git-ignores available-*.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just blindly copypasted the upload-documentation.sh
where the outadeted json is updated 🙈
|
||
pushd ${WORKSPACE} | ||
|
||
wget -q http://docs.jboss.org/hibernate/_available-versions/${PROJECT}.json -O "available-${PROJECT}.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wget -q http://docs.jboss.org/hibernate/_available-versions/${PROJECT}.json -O "available-${PROJECT}.json" | |
wget -q http://docs.jboss.org/hibernate/_data/${PROJECT}/releases.json -O "releases.json" |
? 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or /series.json
, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That being said, we can probably expose this -- and much more -- at hibernate.org/_data/${PROJECT}.json
. Like, much, much more. Series, releases, links to docs -- you name it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rigth ... if we go with hibernate.org
there'd be some cors update required I assume 😃
and if it's hibernate.org you mean it'll be a part of the ruby website build, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that's what I meant.
Yes we'd need cors updates, but I think it's defined in HTML headers, which we'd have modify anyway... no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, we just don't do it yet as for now all files come from the same server. but adding that cors in shouldn't be a problem, just need to keep in mind that orm is doing it not with these scripts 😃
I'll take a look at adding it to hibernate.org later today (or this week)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No rush, Marko. Maybe let's talk again before you do that? I'm sure you have plenty on your hands already :)
a new JSON file
docs_htdocs/hibernate/_available-versions/${PROJECT}.json
that will simply have an array of versions:And then we can use that in the script to populate the dropdown in the docs...
I've tried to add it in a way that wouldn't require us to go and update project builds.
If this makes sense, I'll go create the files with the current versions and then update the js in orm (as a first step to share this between projects)