Skip to content

add to /examples #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 18, 2022
Merged

add to /examples #17

merged 10 commits into from
Nov 18, 2022

Conversation

brookesargent
Copy link
Contributor

@brookesargent brookesargent commented Nov 17, 2022

Which problem is this PR solving?

Fills in /examples with use cases for the top-level module as well as the individual submodules. I validated each example successfully applies and gets log data flowing to Honeycomb with the exception of Postgres, which will require digging into further. (I plan to investigate postgres this afternoon or first thing monday)

Short description of the changes

Borrows heavily from our tests to add deployable examples that can be used as use case documentation and an easy way for users to see how the integrations work.

How to verify that this has the expected result

Each example should be successful in deploying to an AWS account and get logs flowing to Honeycomb.

@brookesargent brookesargent marked this pull request as ready for review November 18, 2022 15:11
@brookesargent brookesargent requested a review from a team as a code owner November 18, 2022 15:11
Copy link
Contributor

@mjayaram mjayaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@brookesargent brookesargent merged commit 2a73b27 into main Nov 18, 2022
@brookesargent brookesargent deleted the brooke.examples branch November 18, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants