Skip to content

Clarify s3-logfile var.name #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion USAGE.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@
## Outputs

No outputs.
<!-- END_TF_DOCS -->
<!-- END_TF_DOCS -->
2 changes: 1 addition & 1 deletion modules/s3-logfile/USAGE.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
| <a name="input_lambda_function_timeout"></a> [lambda\_function\_timeout](#input\_lambda\_function\_timeout) | Timeout in seconds for lambda function. | `number` | `600` | no |
| <a name="input_lambda_package_bucket"></a> [lambda\_package\_bucket](#input\_lambda\_package\_bucket) | Internal. Override S3 bucket where lambda function zip is located. | `string` | `""` | no |
| <a name="input_lambda_package_key"></a> [lambda\_package\_key](#input\_lambda\_package\_key) | Internal. Override S3 key where lambda function zip is located. | `string` | `""` | no |
| <a name="input_name"></a> [name](#input\_name) | A name for this Integration. | `string` | n/a | yes |
| <a name="input_name"></a> [name](#input\_name) | A name for this integration.<br> Used for the lambda name, so should be unique within your AWS account. | `string` | n/a | yes |
| <a name="input_parser_type"></a> [parser\_type](#input\_parser\_type) | The type of logfile to parse. | `string` | n/a | yes |
| <a name="input_rename_fields"></a> [rename\_fields](#input\_rename\_fields) | Map of fields to rename, old -> new. | `map(string)` | `{}` | no |
| <a name="input_s3_bucket_arn"></a> [s3\_bucket\_arn](#input\_s3\_bucket\_arn) | The full ARN of the bucket storing load balancer access logs. | `string` | n/a | yes |
Expand Down
2 changes: 1 addition & 1 deletion modules/s3-logfile/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ module "s3_processor" {
source = "terraform-aws-modules/lambda/aws"
version = "~> 4.2"

function_name = "${var.name}-honeycomb-lb-log-parser"
function_name = var.name
description = "Parses LB access logs from S3, sending them to Honeycomb as structured events"
handler = "s3-handler"
runtime = "go1.x"
Expand Down
5 changes: 4 additions & 1 deletion modules/s3-logfile/variables.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
variable "name" {
type = string
description = "A name for this Integration."
description = <<DESC
A name for this integration.
Used for the lambda name, so should be unique within your AWS account.
DESC
}

variable "environment" {
Expand Down