Skip to content

Add output type = latent for inpainting pipeline #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abdellah-lamrani-alaoui
Copy link

@abdellah-lamrani-alaoui abdellah-lamrani-alaoui commented Mar 28, 2023

Closes #2768.

Context:
The output type "latent" is not handled correctly in the inpainting pipeline, the pipeline returned the decoded latents instead of the latents.
It may cause unexpected behaviours, for instance adapting the code in the huggingface documentation for the inpainting pipeline is not working.

Next steps to go further:

  • Create a method that handles the postprocessing according to the output type and add it to all SD pipelines
  • Add unit tests for the newly created method

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@patrickvonplaten
Copy link
Contributor

cc @yiyixuxu

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Apr 2, 2023

Hi @abdellah-lamrani-alaoui:

Thanks for the PR! We recently created a new class VAEImageProcessor that's intended to provide a unified API for both pre-processing and post-processing

see PR here #2943 - feel free to share your thoughts there :)

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Apr 28, 2023
@github-actions github-actions bot closed this May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants