Skip to content

Remove second instance of scale_lr #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove second instance of scale_lr #3319

wants to merge 1 commit into from

Conversation

ethansmith2000
Copy link
Contributor

lr gets scaled twice

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@patrickvonplaten patrickvonplaten requested a review from sayakpaul May 3, 2023 16:36
@patrickvonplaten
Copy link
Contributor

@sayakpaul can you take a look here as well?

@sayakpaul
Copy link
Member

It's once now actually:

Fixed in #3299

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jun 2, 2023
@github-actions github-actions bot closed this Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants