Skip to content

Enhance STM library readability - Golden tests #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

curiecrypt
Copy link
Collaborator

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2568

Copy link

github-actions bot commented Jul 16, 2025

Test Results

    4 files  ± 0    154 suites  ±0   23m 8s ⏱️ - 1m 27s
2 125 tests + 7  2 125 ✅ + 7  0 💤 ±0  0 ❌ ±0 
6 487 runs  +21  6 487 ✅ +21  0 💤 ±0  0 ❌ ±0 

Results for commit 793b198. ± Comparison against base commit f19a476.

This pull request removes 3 and adds 10 tests. Note that renamed tests count towards both.
mithril-cardano-node-chain ‑ chain_observer::cli_observer::tests::test_cli_devnet_runner
mithril-client ‑ utils::bootstrap_files::test::create_bootstrap_node_files_creates_protocol_magic_id_and_clean_files_for_testnet
mithril-client ‑ utils::bootstrap_files::test::create_bootstrap_node_files_does_not_create_protocol_magic_id_file_and_create_clean_file_for_devnet
mithril-client ‑ utils::bootstrap_files::test::create_bootstrap_node_files_creates_protocol_magic_id_file_and_create_clean_file_for_devnet
mithril-client ‑ utils::bootstrap_files::test::create_bootstrap_node_files_does_not_create_protocol_magic_id_file_and_create_clean_file_for_private_network
mithril-common ‑ entities::cardano_network::tests::cardano_network_from_magic_id_roundtrip
mithril-stm ‑ bls_multi_signature::proof_of_possession::tests::golden::golden_conversions
mithril-stm ‑ bls_multi_signature::signature::tests::golden::golden_conversions
mithril-stm ‑ bls_multi_signature::signing_key::tests::golden::golden_conversions
mithril-stm ‑ bls_multi_signature::verification_key::tests::golden::golden_conversions
mithril-stm ‑ parameters::tests::golden::golden_conversions
mithril-stm ‑ participant::initializer::tests::golden::golden_conversions
mithril-stm ‑ single_signature::signature::tests::golden::golden_conversions

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt temporarily deployed to testing-preview July 18, 2025 15:51 — with GitHub Actions Inactive
@curiecrypt curiecrypt temporarily deployed to testing-preview July 18, 2025 16:20 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants