Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Use host device explicitly and add default ctor tests #1169

Conversation

steffenlarsen
Copy link

SYCL2020 changes the default constructor of both platform and device from using host to using the objects associated with the default device selector. This commit adjusts for this change in behaviour.
Additionally, this commit also adds tests for the default constructor behaviour for both platform and device.

SYCL2020 changes the default constructor of both platform and device
from using host to using the objects associated with the default device
selector. This commit adjusts for this change in behaviour.
Additionally, this commit also adds tests for the default constructor
behaviour for both platform and device.

Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen
Copy link
Author

@againull - Friendly ping.

Copy link

@againull againull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay! LGTM

@steffenlarsen steffenlarsen merged commit 8c8996a into intel:intel Aug 25, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
)

SYCL2020 changes the default constructor of both platform and device
from using host to using the objects associated with the default device
selector. This commit adjusts for this change in behaviour.
Additionally, this commit also adds tests for the default constructor
behaviour for both platform and device.

Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…lvm-test-suite#1169)

SYCL2020 changes the default constructor of both platform and device
from using host to using the objects associated with the default device
selector. This commit adjusts for this change in behaviour.
Additionally, this commit also adds tests for the default constructor
behaviour for both platform and device.

Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants