This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Test for set_final_data(..) method #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
s-kanaev
reviewed
Jan 29, 2021
| if (data_vector[i] != true) | ||
| assert(false); | ||
| } | ||
| } |
|
Also, there're tests for |
vladimirlaz
suggested changes
Jan 29, 2021
|
|
||
| for (size_t i = 0; i < size; i++) { | ||
| if (data_vector[i] != true) | ||
| assert(false); |
There was a problem hiding this comment.
can you write some message and return 1 to be more user friendly?
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
|
@s-kanaev The test was moved to the buffer.cpp. It was extracted for int and double types. |
romanovvlad
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 1, 2021
Fixed set_final_data() taking std::vector<bool> which was not compiling because such a vector has no data method. The patch adds a special case for bool type. Test: intel/llvm-test-suite#122 Signed-off-by: mdimakov [email protected]
vladimirlaz
approved these changes
Feb 3, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Signed-off-by: mdimakov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mdimakov [email protected]