This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Removed handler::codeplay_host_task #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mdimakov <[email protected]>
SYCL/Basic/host-task-dependency.cpp
Outdated
| @@ -98,11 +94,11 @@ template <bool UseSYCL2020HostTask> void Thread1Fn(Context *Ctx) { | |||
| GeneratorAcc[Idx] = Idx; | |||
| }; | |||
|
|
|||
| CGH.single_task<NameGen<class Gen, UseSYCL2020HostTask>>(GeneratorKernel); | |||
| CGH.single_task<NameGen<class Gen, true>>(GeneratorKernel); | |||
There was a problem hiding this comment.
Does second template parameter still required in NameGen? Can it be removed?
Does it mean that this patch removes handler::codeplay_host_task in this patch? If yes, it should be smth like: "and will be removed" -> "and is removed in this patch" |
|
@dm-vodopyanov I changed the comment |
romanovvlad
pushed a commit
to intel/llvm
that referenced
this pull request
Sep 9, 2021
handler::codeplay_host_task is deprecated in SYCL 2020. This patch depends on : Changes in Lit Tests : intel/llvm-test-suite#428 and intel/llvm-test-suite#451 Signed-off-by: mdimakov [email protected]
DoyleLi
pushed a commit
to DoyleLi/intel_llvm
that referenced
this pull request
Sep 13, 2021
handler::codeplay_host_task is deprecated in SYCL 2020. This patch depends on : Changes in Lit Tests : intel/llvm-test-suite#428 and intel/llvm-test-suite#451 Signed-off-by: mdimakov [email protected]
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Signed-off-by: mdimakov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handler::codeplay_host_task is deprecated and is removed in the patch intel/llvm#4426
Signed-off-by: mdimakov [email protected]