This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add test for correctly rounded sqrt #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL/DeviceLib/sqrt.cpp
Outdated
Comment on lines
47
to
55
| float diff = 0.0f; | ||
| for (int i = 0; i < input.size(); ++i) { | ||
| diff += fabs(expected[i] - output[i]); | ||
| } | ||
|
|
||
| if (diff > 0.0f) { | ||
| std::cerr << "Incorrectly rounded sqrt, total diff: " << diff << std::endl; | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
It think it would be better to do the check in the loop rather than on the total difference. In case it starts failing, the additional information about which i failed might help debug.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is testing the flag introduced in:
And should only be merged after that PR is merged.