This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Test rework for SYCL_DEVICE_FILTER=device_num #775
Merged
vladimirlaz
merged 1 commit into
intel:intel
from
KseniyaTikhomirova:device-filter-check-test
Feb 7, 2022
Merged
[SYCL] Test rework for SYCL_DEVICE_FILTER=device_num #775
vladimirlaz
merged 1 commit into
intel:intel
from
KseniyaTikhomirova:device-filter-check-test
Feb 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression test now partly duplicates RT logic of device choice and should catch any regressions there. Signed-off-by: Tikhomirova, Kseniya <[email protected]>
/verify with intel/llvm#5349 |
@bso-intel Could you please review new test design aligned with expected RT behavior? |
few notes about pre-commit checks:
@bso-intel could you please review the test? |
bso-intel
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
hi @intel/llvm-reviewers-runtime, this commit depends on intel/llvm#5349, tests with it are passed, could you please take a look and merge if no concerns? |
vladimirlaz
approved these changes
Feb 7, 2022
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
Additional commits from upstream repo https://github.com/intel/llvm-test-suite: da7e36e [SYCL] Test rework for SYCL_DEVICE_FILTER=device_num (intel#775) cc8ee1e [SYCL] Use the sycl:: namespace instead of cl::sycl:: one (intel#749) 47a4b5b [SYCL][L0] check USM capabilities (intel#794) f5cfbca [SYCL] Change name of macro to enable fallback assert (intel#754) 38486e7 [ESIMD] Add smoke test for simd_obj_impl::any/all. (intel#802)
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
Additional commits from upstream repo https://github.com/intel/llvm-test-suite: da7e36e [SYCL] Test rework for SYCL_DEVICE_FILTER=device_num (intel#775) cc8ee1e [SYCL] Use the sycl:: namespace instead of cl::sycl:: one (intel-innersource#749) 47a4b5b [SYCL][L0] check USM capabilities (intel#794) f5cfbca [SYCL] Change name of macro to enable fallback assert (intel#754) 38486e7 [ESIMD] Add smoke test for simd_obj_impl::any/all. (intel#802)
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…-suite#775) Regression test now partly duplicates RT logic of device choice and should catch any regressions there. Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression test now partly duplicates RT logic of device choice and
should catch any regressions there.
Signed-off-by: Tikhomirova, Kseniya [email protected]