Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Test rework for SYCL_DEVICE_FILTER=device_num #775

Merged

Conversation

KseniyaTikhomirova
Copy link

Regression test now partly duplicates RT logic of device choice and
should catch any regressions there.

Signed-off-by: Tikhomirova, Kseniya [email protected]

Regression test now partly duplicates RT logic of device choice and
should catch any regressions there.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova
Copy link
Author

/verify with intel/llvm#5349

@KseniyaTikhomirova
Copy link
Author

@bso-intel Could you please review new test design aligned with expected RT behavior?

@KseniyaTikhomirova
Copy link
Author

few notes about pre-commit checks:

  1. please pay attention to check with dependent pull request otherwise device_num test fails.
  2. failed checks there is caused by known issues and [SYCL] Disabling failing tests on Windows #785 and [SYCL] Remove broken atomic_memory_order* tests #783 disables them.

@bso-intel could you please review the test?

Copy link

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KseniyaTikhomirova
Copy link
Author

KseniyaTikhomirova commented Feb 2, 2022

hi @intel/llvm-reviewers-runtime, this commit depends on intel/llvm#5349, tests with it are passed, could you please take a look and merge if no concerns?

@vladimirlaz vladimirlaz merged commit da7e36e into intel:intel Feb 7, 2022
myler added a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
Additional commits from upstream repo https://github.com/intel/llvm-test-suite:
da7e36e [SYCL] Test rework for SYCL_DEVICE_FILTER=device_num (intel#775)
cc8ee1e [SYCL] Use the sycl:: namespace instead of cl::sycl:: one (intel#749)
47a4b5b [SYCL][L0] check USM capabilities (intel#794)
f5cfbca [SYCL] Change name of macro to enable fallback assert (intel#754)
38486e7 [ESIMD] Add smoke test for simd_obj_impl::any/all. (intel#802)
myler added a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
Additional commits from upstream repo https://github.com/intel/llvm-test-suite:
da7e36e [SYCL] Test rework for SYCL_DEVICE_FILTER=device_num (intel#775)
cc8ee1e [SYCL] Use the sycl:: namespace instead of cl::sycl:: one (intel-innersource#749)
47a4b5b [SYCL][L0] check USM capabilities (intel#794)
f5cfbca [SYCL] Change name of macro to enable fallback assert (intel#754)
38486e7 [ESIMD] Add smoke test for simd_obj_impl::any/all. (intel#802)
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…-suite#775)

Regression test now partly duplicates RT logic of device choice and
should catch any regressions there.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants