Skip to content

[SYCL][InvokeSimd] Add error for callee with struct return or argument #10121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jun 28, 2023

It doesn't work at runtime even if we make it through the compiler because of an IGC issue.

Once the IGC issue is fixed, we will need make some changes to the compiler and then lift this restriction.

@sarnex sarnex temporarily deployed to aws June 28, 2023 21:58 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor Author

sarnex commented Jun 29, 2023

********************
Timed Out Tests (1):
  SYCL :: HostInteropTask/host-task-dependency4.cpp

not related

@sarnex sarnex marked this pull request as ready for review June 29, 2023 14:20
@sarnex sarnex requested review from a team and rolandschulz as code owners June 29, 2023 14:20
@sarnex
Copy link
Contributor Author

sarnex commented Jun 30, 2023

I'll be on vacation until July 26th, I'll address any feedback then. Thanks!

sarnex added 2 commits July 27, 2023 07:47
It doesn't work at runtime even if we make it through the compiler because of an IGC issue, and sometimes it won't make it through the compiler because we don't have sret correctly.

Once the IGC issue is fixed, we will need make some changes to the compiler and then lift this restriction.

Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex changed the title [SYCL][InvokeSimd] Add error for callee returning struct [SYCL][InvokeSimd] Add error for callee with struct return or argument Jul 27, 2023
@sarnex sarnex temporarily deployed to aws July 27, 2023 15:04 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to aws July 27, 2023 15:43 — with GitHub Actions Inactive
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex temporarily deployed to aws July 27, 2023 19:41 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to aws July 27, 2023 20:21 — with GitHub Actions Inactive
@v-klochkov
Copy link
Contributor

HIP/AMD fails like this are unrelated to this PR:
what(): No device of requested type available. -1 (PI_ERROR_DEVICE_NOT_FOUND)

@v-klochkov v-klochkov merged commit 03c13fd into intel:sycl Jul 28, 2023
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
intel#10121)

It doesn't work at runtime even if we make it through the compiler
because of an IGC issue.

Once the IGC issue is fixed, we will need make some changes to the
compiler and then lift this restriction.

---------

Signed-off-by: Sarnie, Nick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants