[SYCL][InvokeSimd] Add error for callee with struct return or argument #10121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not related |
|
I'll be on vacation until July 26th, I'll address any feedback then. Thanks! |
turinevgeny
approved these changes
Jul 7, 2023
v-klochkov
reviewed
Jul 10, 2023
It doesn't work at runtime even if we make it through the compiler because of an IGC issue, and sometimes it won't make it through the compiler because we don't have sret correctly. Once the IGC issue is fixed, we will need make some changes to the compiler and then lift this restriction. Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
sarnex
changed the title
v-klochkov
reviewed
Jul 27, 2023
Signed-off-by: Sarnie, Nick <[email protected]>
v-klochkov
approved these changes
Jul 27, 2023
|
HIP/AMD fails like this are unrelated to this PR: |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
intel#10121) It doesn't work at runtime even if we make it through the compiler because of an IGC issue. Once the IGC issue is fixed, we will need make some changes to the compiler and then lift this restriction. --------- Signed-off-by: Sarnie, Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work at runtime even if we make it through the compiler because of an IGC issue.
Once the IGC issue is fixed, we will need make some changes to the compiler and then lift this restriction.