[SYCL][PI] Change const to constexpr to make GCC happy #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Brodman <[email protected]>
bader
previously approved these changes
Jan 15, 2020
|
Only the latest VS accepts "constexpr". Are we ok with some preprocessor #if s? Clang/MSVC take "const". GCC before 7.2 requires "constexpr" |
Signed-off-by: James Brodman <[email protected]>
mlychkov
reviewed
Jan 16, 2020
|
Also we can consider using array of strings and enum values of which maps to corresponding values in the array: |
vladimirlaz
previously approved these changes
Jan 16, 2020
|
I suggest to submit the change to unblock the build and then implement improvements |
Signed-off-by: James Brodman <[email protected]>
bader
approved these changes
Jan 16, 2020
|
Ok I have no clue why that test failed. |
This is flacky test. Please ignore it. |
keryell
reviewed
Jan 18, 2020
| CONSTFIX char clEnqueueMemcpyName[] = "clEnqueueMemcpyINTEL"; | ||
| CONSTFIX char clEnqueueMigrateMemName[] = "clEnqueueMigrateMemINTEL"; | ||
| CONSTFIX char clEnqueueMemAdviseName[] = "clEnqueueMemAdviseINTEL"; | ||
| CONSTFIX char clGetMemAllocInfoName[] = "clGetMemAllocInfoINTEL"; |
There was a problem hiding this comment.
I was actually thinking to just
auto constexpr clHostMemAllocName = "clHostMemAllocINTEL";
but it might not work on some old compilers... Who cares about old compilers? SYCL is about the future. :-)
| CONSTFIX char clEnqueueMemAdviseName[] = "clEnqueueMemAdviseINTEL"; | ||
| CONSTFIX char clGetMemAllocInfoName[] = "clGetMemAllocInfoINTEL"; | ||
|
|
||
| #undef CONSTFIX |
There was a problem hiding this comment.
__SYCL_CONST_FIX to limit the risk of collision?
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
…#1017) The behavior of -fsycl-instrument-device-code has modified the requirements for tests which perform separate compilation. Update these tests to pull in the needed device code to alleviate issues as seen below: Error: unimplemented function(s) used: __itt_offload_wi_start_wrapper is undefined __itt_offload_wi_finish_wrapper is undefined CompilerException Failed to parse IR -17 (CL_LINK_PROGRAM_FAILURE) Signed-off-by: Michael D Toguchi [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC older than 7.2 requires constexpr instead of const.
Signed-off-by: James Brodman [email protected]