[CI][HIP] Install libstdc++-12-dev without gcc12. #13752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <[email protected]>
| apt-get install -yqq gcc-12 g++-12 libstdc++-12-dev && \ | ||
| update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-12 100 && \ | ||
| update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-12 100 | ||
| apt-get install -yqq libstdc++-12-dev |
There was a problem hiding this comment.
Can it be just libstdc++-dev to match the system gcc installation?
There was a problem hiding this comment.
Unfortunately it doesn't work with libstdc++-11-dev: you get the old
/llvm/libdevice/imf_impl_utils.hpp:12:10: fatal error: 'cstddef' file not found
12 | #include <cstddef>
aelovikov-intel
approved these changes
May 10, 2024
sarnex
pushed a commit
that referenced
this pull request
May 13, 2024
Switch to using apt packages instead of amdgpu-install. This uses c++-11-dev libraries so hopefully avoids the problems caused by #13752 Signed-off-by: JackAKirk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts the changes made in #13619 to use libstdc++-12-dev without gcc12.
This also seems to work fine to build dpc++ within the docker. But should come without the CI failures that might have been induced by the gcc uplift:
If the above issues were not caused by the gcc version uplift, then this patch should also reveal that.