Skip to content

[SYCL Joint Matrix][E2E] Add 1d vector load/store tests for big combinations #13814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

YuriPlyakhin
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin commented May 16, 2024

This change is partially addressing requirement to enable 1d block load testing (IGC_JointMatrixLoadStoreOpt=2) for only big combinations 32x64x16, 1x64x16, 16x16x16.
This environment variable was added to as minimum tests as possible, while keeping the coverage of big combinations to maximum.
This environment variable was not added to Matrix/element_wise_ops.cpp yet, because, IGC compiler needs to be fixed to pass this test with IGC_JointMatrixLoadStoreOpt=2

@YuriPlyakhin YuriPlyakhin changed the title Add 1d load [SYCL Joint Matrix][E2E] Add 1d vector load/store tests for big combinations May 21, 2024
@YuriPlyakhin YuriPlyakhin marked this pull request as ready for review May 21, 2024 19:29
@YuriPlyakhin YuriPlyakhin requested a review from a team as a code owner May 21, 2024 19:29
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in the description why only these tests were added the env var?
Are these only tests that contains big combination support?
What about Matrix/element_wise_ops.cpp?

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriPlyakhin
Copy link
Contributor Author

@intel/llvm-gatekeepers , all green, please, merge

@sarnex sarnex merged commit 306e5ff into intel:sycl May 22, 2024
@YuriPlyakhin YuriPlyakhin deleted the add_1d_load branch May 22, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants