Skip to content

[SYCL] Enable JIT tests relying on debug output #14801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 22, 2024

Conversation

jchlanda
Copy link
Contributor

@jchlanda jchlanda commented Jul 26, 2024

Wrap the tests in REQUIRE: asserts in order to make sure that the compiler can generate the messages.

Also make sure we don't run the e2e tests on windows, as JIT is not supported there.

Wrap the tests in `REQUIRE: asserts` in order to make sure that the
compiler can generate the messages.
@jchlanda jchlanda requested a review from sarnex July 26, 2024 13:21
@jchlanda jchlanda requested review from a team as code owners July 26, 2024 13:21
@jchlanda jchlanda requested a review from maarquitos14 July 26, 2024 13:21
@jchlanda
Copy link
Contributor Author

Fixes #14783

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jchlanda jchlanda closed this Jul 29, 2024
@jchlanda jchlanda reopened this Jul 29, 2024
@jchlanda
Copy link
Contributor Author

I had to introduce a dedicated feature has_ndebug in order to be able to reliably test the debug output. I decided to remove the debug test form sycl-fusion's directory, as in order to enable a has_ndebug feature there we would first need to teach it about the dpcpp_compiler and that seemed like too much of a hustle for this purpose.

@ldrumm, you might want to have a quick look at this, thank you!

@jchlanda
Copy link
Contributor Author

Fixes #14989

@jchlanda
Copy link
Contributor Author

Friendly ping @sarnex (and @maarquitos14, somehow your previous 👍 disappeared).

Thank you.

@jchlanda
Copy link
Contributor Author

@intel/llvm-gatekeepers this should be ready to go, thank you.

@sommerlukas sommerlukas merged commit 27cea9f into intel:sycl Aug 22, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants