-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] Enable JIT tests relying on debug output #14801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wrap the tests in `REQUIRE: asserts` in order to make sure that the compiler can generate the messages.
Fixes #14783 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I had to introduce a dedicated feature @ldrumm, you might want to have a quick look at this, thank you! |
Fixes #14989 |
Friendly ping @sarnex (and @maarquitos14, somehow your previous 👍 disappeared). Thank you. |
42f5ef9
to
f78eed1
Compare
@intel/llvm-gatekeepers this should be ready to go, thank you. |
Wrap the tests in
REQUIRE: asserts
in order to make sure that the compiler can generate the messages.Also make sure we don't run the e2e tests on windows, as JIT is not supported there.