Skip to content

[CI][SYCL-CTS] Small improvements #14807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2024
Merged

[CI][SYCL-CTS] Small improvements #14807

merged 4 commits into from
Aug 7, 2024

Conversation

KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Jul 26, 2024 •
edited
Loading

Remove step "List excluded SYCL CTS categories" due to duplicated code.
List cts-filter in the "Build SYCL CTS tests" step instead.
Also remove DSYCL_CTS_MEASURE_BUILD_TIMES. It affects the performance, but we don't use these results.

@KornevNikita
[CI][SYCL-CTS] Small improvements
8212d04 
Also remove DSYCL_CTS_MEASURE_BUILD_TIMES. It affects the performance,
but we don't use these results.
@KornevNikita KornevNikita requested a review from a team as a code owner July 26, 2024 16:17
@KornevNikita
Copy link
Contributor Author

@aelovikov-intel is it what you were talking about?

aelovikov-intel
aelovikov-intel reviewed Jul 26, 2024
View reviewed changes
@KornevNikita
Copy link
Contributor Author

test runs:
GPU: https://github.com/intel/llvm/actions/runs/10159377952
CPU: https://github.com/intel/llvm/actions/runs/10159374251
Fails are expected due to pi-port, I turned them off in another PR, but didn't update this branch.

aelovikov-intel
aelovikov-intel reviewed Jul 30, 2024
View reviewed changes
aelovikov-intel
aelovikov-intel reviewed Jul 31, 2024
View reviewed changes
.github/workflows/sycl-linux-run-tests.yml
fi

cmake -GNinja -B./build-cts -S./khronos_sycl_cts -DCMAKE_CXX_COMPILER=$(which clang++) \
-DSYCL_IMPLEMENTATION=DPCPP \
-DSYCL_CTS_EXCLUDE_TEST_CATEGORIES="$cts_exclude_filter" \
-DSYCL_CTS_ENABLE_OPENCL_INTEROP_TESTS=OFF \
-DSYCL_CTS_MEASURE_BUILD_TIMES=ON \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we dropping this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned this in the commit message (hope I'm not wrong)

Also remove DSYCL_CTS_MEASURE_BUILD_TIMES. It affects the performance, but we don't use these results.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aelovikov-intel should I remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think it's better without it, then dropping it is fine. You're the one working with the CTS runs in CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I'd prefer to drop it

@KornevNikita KornevNikita reopened this Aug 7, 2024
@KornevNikita
Copy link
Contributor Author

AFAIU #14980 should fix the failure.
@intel/llvm-gatekeepers could you please merge

@steffenlarsen
Copy link
Contributor

@KornevNikita - Could you please summarize the improvements made in the description?

@KornevNikita
Copy link
Contributor Author

@steffenlarsen done

@steffenlarsen steffenlarsen merged commit 31b6ba1 into sycl Aug 7, 2024
35 of 38 checks passed
@bader bader deleted the improve-nightly-cts branch September 17, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KornevNikita @steffenlarsen @aelovikov-intel