Skip to content

[SYCL] Add dependency.conf with external dependencies for SYCL #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2020
Merged

[SYCL] Add dependency.conf with external dependencies for SYCL #1555

merged 1 commit into from
May 16, 2020

Conversation

yanfeng3721
Copy link
Contributor

Signed-off-by: Yanfeng Xiao [email protected]

@yanfeng3721 yanfeng3721 requested a review from bader as a code owner April 20, 2020 13:29
@yanfeng3721 yanfeng3721 force-pushed the UpliftBeta06 branch 2 times, most recently from b3c8046 to 186490a Compare April 21, 2020 06:58
bader
bader requested changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanfeng3721, please address the regressions.

@yanfeng3721
Copy link
Contributor Author

There are two regression on LIT test
FAIL: SYCL::hier_par_basic.cpp
FAIL: SYCL::info.cpp

@yanfeng3721 yanfeng3721 requested a review from a team as a code owner April 30, 2020 11:22
@yanfeng3721 yanfeng3721 requested a review from vladimirlaz April 30, 2020 11:22
@vladimirlaz vladimirlaz force-pushed the UpliftBeta06 branch 2 times, most recently from 70b71c5 to ff0a6af Compare April 30, 2020 13:31
vladimirlaz
vladimirlaz previously approved these changes Apr 30, 2020
View reviewed changes
@vladimirlaz vladimirlaz requested a review from bader April 30, 2020 19:13
bader
bader reviewed Apr 30, 2020
View reviewed changes
bader
bader reviewed May 1, 2020
View reviewed changes
@vladimirlaz
Copy link
Contributor

vladimirlaz commented May 6, 2020 •
edited
Loading

For GPU RT we have at least https://github.com/otcshare/llvm/pull/987 waiting for the upgrade according to @AGindinson

@bader bader mentioned this pull request May 9, 2020
Closed
@vladimirlaz vladimirlaz force-pushed the UpliftBeta06 branch 3 times, most recently from 51d1e22 to 38b7bea Compare May 14, 2020 16:14
@vladimirlaz
Copy link
Contributor

I will do documentation update and fix missing links in next patches.

@vladimirlaz vladimirlaz requested a review from pvchupin May 14, 2020 17:35
pvchupin
pvchupin suggested changes May 14, 2020
View reviewed changes
Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe versions are wrong.

@vladimirlaz vladimirlaz force-pushed the UpliftBeta06 branch 5 times, most recently from 7de4e76 to d4cb986 Compare May 15, 2020 08:26
@vladimirlaz vladimirlaz requested a review from pvchupin May 15, 2020 14:34
@bader bader mentioned this pull request May 15, 2020
Merged
@vladimirlaz vladimirlaz requested review from bader and vladimirlaz May 15, 2020 17:41
bader
bader previously approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladimirlaz, please, create a follow-up review with update to the documentation (GetStartedGuide and ReleaseNotes) with instructions where how to get and install external dependencies.

@bader
Copy link
Contributor

bader commented May 15, 2020

@pvchupin, ping.

pvchupin
pvchupin previously approved these changes May 15, 2020
View reviewed changes
@vladimirlaz
Copy link
Contributor

@vladimirlaz, please, create a follow-up review with update to the documentation (GetStartedGuide and ReleaseNotes) with instructions where how to get and install external dependencies.

@bader, I will do that early next week

bader
bader reviewed May 15, 2020
View reviewed changes
bader
bader reviewed May 15, 2020
View reviewed changes
@yanfeng3721 @vladimirlaz
[SYCL] Add information about dependencies used in CI
d767b85 
 - dependency.conf file is added;
 - uplift the dependencies versions for upcoming release;
 - align LIT test statuses with new runtimes.
@vladimirlaz vladimirlaz dismissed stale reviews from pvchupin and bader via d767b85 May 15, 2020 19:13
@bader
Copy link
Contributor

bader commented May 15, 2020

@vladimirlaz, please, review as intel/llvm-reviewers-runtime member.

@bader bader changed the title [SYCL]Add dependency.conf and uplift the deps version [SYCL] Add dependency.conf with external dependencies for SYCL May 15, 2020
@vladimirlaz vladimirlaz merged commit ad575b5 into intel:sycl May 16, 2020
bader
bader reviewed May 17, 2020
View reviewed changes
sycl/test/spec_const/spec_const_hw.cpp
@@ -5,7 +5,8 @@
// RUN: %ACC_RUN_PLACEHOLDER %t.out
// TODO: re-enable after CI drivers are updated to newer which support spec
// constants:
// XFAIL: acc,cpu,cuda,gen
// XFAIL: linux
// UNSUPPORTED: cuda
Copy link
Contributor

@bader bader May 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. Post-commit testing is failing due to “expected to fail” condition.
There are a few ways how to fix it, but I guess the easiest one is to replace:

// UNSUPPORTED: cuda

with

// REQUIRES: opencl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

@pvchupin pvchupin pvchupin left review comments

@vladimirlaz vladimirlaz Awaiting requested review from vladimirlaz

Assignees

@vladimirlaz vladimirlaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanfeng3721 @vladimirlaz @bader @v-klochkov @pvchupin