[UR][HIP] Fix HIP adapter compilation on Windows #17702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting ur_context_info_t (int32_t) to uint32_t was a narrowing conversion and it was making Visual Studio compiler error out during compilation.
npmiller
approved these changes
Mar 28, 2025
|
@intel/llvm-gatekeepers This is ready to merge It looks like the PVC machine is down again, so the E2E jobs on that failed. But this PR only touches the HIP adapter, and it's build fixes for Windows so it shouldn't affect the PVC tests. |
|
I'm happy to merge this, as you say it's unlikely this job will fail if the PVC runner was online |
npmiller
added a commit
to npmiller/llvm
that referenced
this pull request
Apr 9, 2025
* Fix links to configure.py and compile.py
* Linking to the file in tree caused the link in the docs to just
download the python script. It makes more sense to link to the
github web UI for these as they should be used in a checkout anyway.
* Remove CUDA requiring device selector
* Since intel#6203 the device selector
should handle this case well.
* Update HIP backend limitations
* HIP is no longer in beta
* Windows isn't supported but intel#17702
made the build work with it so it might work for some users.
* Global offset has been supported since intel#5855
* Add common limitations
* Update HIP for Nvidia section
* This might work but is not supported
* Update HIP section
* Recommended HIP version + testing platforms
* HIP is no longer in beta
* Add note on target aliases for CUDA and HIP
kbenzie
pushed a commit
that referenced
this pull request
Apr 28, 2025
* Fix links to configure.py and compile.py * Linking to the file in tree caused the link in the docs to just download the python script. It makes more sense to link to the github web UI for these as they should be used in a checkout anyway. * Remove CUDA requiring device selector * Since #6203 the device selector should handle this case well. * Update HIP backend limitations * HIP is no longer in beta * Windows isn't supported but #17702 made the build work with it so it might work for some users. * Global offset has been supported since #5855 * Add common limitations * Update HIP for Nvidia section * This might work but is not supported * Update HIP section * Recommended HIP version + testing platforms * HIP is no longer in beta * Add note on target aliases for CUDA and HIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have access to a device to validate it's all perfect at runtime, but these fixes did let me build everything successfully, and the compiler was able to build Blender GPU kernels library on Windows, using HIP SDK 6.2.4 and VS2022 17.12.1.