[clang] Add support for SYCL templated free functions declared in namespaces #17936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SYCL] fix formatting [SYCL] remove unnecessary space
…namespace-support
[SYCL] include additional header in tests [SYCL] do not iterate through arguments twice
…namespace-support
…namespace-support
dklochkov-emb
changed the title
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fznamznon
approved these changes
Apr 30, 2025
sycl/test/extensions/free_function_kernels/free_function_kernels_diagnostics.cpp
Outdated
Show resolved
Hide resolved
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Co-authored-by: Mariya Podchishchaeva <[email protected]>
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please, merge it |
|
Still waiting on @intel/llvm-reviewers-runtime Also, @steffenlarsen's point was not addressed |
steffenlarsen
approved these changes
May 5, 2025
There was a problem hiding this comment.
Remaining open is a Nit, so I'll let @dklochkov-emb decide what to do with it. Here's a sticky approval. 🚀
|
@ldrumm Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of templated free function declared both in namespace or not. Support of accessor types should be added in a separate PR because it requires effort not only on the frontend side.
Docs: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc