[SYCL][NativeCPU] Copy over more host/aux target data. #17999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hvdijk
commented
Apr 14, 2025
hvdijk
commented
- Use copyAuxTarget instead of copying over each field.
- Copy over TargetOpts as well.
- Prevent recording the target flags for builtins.
* Use copyAuxTarget instead of copying over each field. * Copy over TargetOpts as well. * Prevent recording the target flags for builtins.
|
Note since it may not be obvious why it's part of this PR: The "Prevent recording the target flags for builtins" needs to be part of this because the additional data that gets recorded would otherwise start including target-specific flags in the builtins, preventing them from being used for cross-compilation. |
npmiller
approved these changes
Apr 14, 2025
mdtoguchi
approved these changes
Apr 15, 2025
Fznamznon
reviewed
Apr 17, 2025
The main goal is to ensure target flags are recorded in the device code in the same way that they are recorded for host code, I've added a test for that, thanks for the suggestion. |
Fznamznon
reviewed
Apr 22, 2025
Fznamznon
approved these changes
Apr 22, 2025
coldav
approved these changes
Apr 22, 2025
|
@intel/llvm-gatekeepers This can be merged, thanks. |
aelovikov-intel
pushed a commit
that referenced
this pull request
May 15, 2025
In #17999 I changed prepare-builtins to clear target-cpu and target-features for NativeCPU, and attempted to preserve existing behavior for other targets. For NativeCPU, two errors cancelled each other out so we do the right thing there, but for other targets, that is not the case and target-cpu and target-features were also being cleared unintentionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.