[UR][L0] Move async pool cleanup after queue sync #18331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
approved these changes
May 6, 2025
In a scenario where the AsyncPool freelist contains an entry tied to a free event that hasn't completed yet, performing freelist cleanup before queue sync can result in freeing memory that's actively in use.
|
The one failing SYCL e2e test, also fails on the CI jobs from other PRs, eg. https://github.com/intel/llvm/actions/runs/14858136399/job/41717560338 and https://github.com/intel/llvm/actions/runs/14857464574/job/41715519649 |
igchor
approved these changes
May 6, 2025
|
@intel/llvm-gatekeepers please merge. The failure is unrelated (#18331 (comment)). |
This was referenced May 6, 2025
KornevNikita
pushed a commit
that referenced
this pull request
May 27, 2025
In a scenario where the AsyncPool freelist contains an entry tied to a free event that hasn't completed yet, performing freelist cleanup before queue sync can result in freeing memory that's actively in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a scenario where the AsyncPool freelist contains an entry tied to a free event that hasn't completed yet, performing freelist cleanup before queue sync can result in freeing memory that's actively in use.