[sycl-rel] Cherry-pick patches for sycl_ext_intel_device_info #18886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
gmlueck
reviewed
Jun 10, 2025
|
This will likely be needed as well: |
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Tests were not added because there are existing conformance tests which cover this functionality.
…ntel#17719) Our pre-commit CI uses CUDA 12.6 but nightly uses CUDA 12.1, it turns out nvml which is part of CUDA 12.6 has nvmlDeviceGetCurrentClocksEventReasons API, but nvml which is part of CUDA 12.1 doesn't have it, but only supports older deprecated nvmlDeviceGetCurrentClocksThrottleReasons. NVML doesn't provide a version macro to check the support for that API, so use new API nvmlDeviceGetCurrentClocksEventReasons based on cuda version.
KornevNikita
force-pushed
the
cherry-pick-sycl_ext_intel_device_info
branch
from
8596557 to
3ffe48b
Compare
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
There was an already cherry-picked commit, so I had to force push. |
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Ignore the pre-commit results, it's stale. Actual test run - https://github.com/intel/llvm/actions/runs/15608181761 @intel/llvm-reviewers-cuda @intel/unified-runtime-reviewers take a look please. |
npmiller
approved these changes
Jun 12, 2025
|
@intel/unified-runtime-reviewers friendly ping |
gmlueck
approved these changes
Jun 17, 2025
|
@kbenzie could you please take a look? |
kbenzie
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick commits that reached the internal branch between intel/llvm cutoff and release branch pulldown.