Skip to content

[DeviceSanitizer] Add assertion to possible nullptr and die when trying to create shadow with unsupported device #19129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yingcong-wu
Copy link
Contributor

@yingcong-wu yingcong-wu commented Jun 25, 2025

Addresses #18333.

@yingcong-wu yingcong-wu requested a review from a team as a code owner June 25, 2025 05:59
@yingcong-wu yingcong-wu requested a review from a team June 25, 2025 05:59
@yingcong-wu yingcong-wu changed the title add assert [DeviceSanitizer] Add assertion to possible nullptr and die when trying to create shadow with unsupported device Jun 25, 2025
@yingcong-wu
Copy link
Contributor Author

yingcong-wu commented Jun 25, 2025

Looks like there are some infrastructure issues? I will try to re-trigger the CI later.

@yingcong-wu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers , the SYCL Pre Commit on Windows / run_prebuilt_e2e_tests (Intel Battlemage Graphics with Level Zero, ["Windows","bmg"]) / Intel Battlemage Graphics with Level Zero (pull_request) Failing after 4m

Failed Tests (3):
SYCL :: Adapters/level_zero/ext_intel_cslice.cpp
SYCL :: Adapters/level_zero/ext_intel_queue_index.cpp
SYCL :: Adapters/sycl-ls-uuid-subdevs.cpp

Unexpectedly Passed Tests (5):
SYCL :: bindless_images/array/fetch_handle_carray2d.cpp
SYCL :: bindless_images/read_1D_O0.cpp
SYCL :: bindless_images/sampled_fetch/fetch_1D_O0.cpp
SYCL :: bindless_images/sampled_fetch/fetch_2D_O0.cpp
SYCL :: bindless_images/sampling_1D_O0.cpp

Testing Time: 180.85s

Total Discovered Tests: 2431
Unsupported : 1147 (47.18%)
Passed : 1265 (52.04%)
Expectedly Failed : 11 (0.45%)
Failed : 3 (0.12%)
Unexpectedly Passed: 5 (0.21%)

is tracked with #18576.

Please help merge this PR, thanks.

@steffenlarsen steffenlarsen merged commit c310aed into intel:sycl Jul 1, 2025
74 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants