-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][Tests] Add more syclbin-dump tests #19272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
@@ -50,19 +50,6 @@ raw_ostream &operator<<(raw_ostream &OS, const ScopedIndent &) { | |||
return OS.indent(CurrentIndentationLevel); | |||
} | |||
|
|||
std::string_view StateToString(llvm::object::SYCLBIN::BundleState State) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed as it was not used and it was affecting the code coverage
sycl/test/syclbin/malformed.syclbin
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this to an Inputs subfolder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good!
No description provided.