Skip to content

[UR][Offload] Implement UR_DEVICE_INFO_MAX_WORK_ITEM_SIZES #19275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[UR][Offload] Implement UR_DEVICE_INFO_MAX_WORK_ITEM_SIZES #19275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions unified-runtime/source/adapters/offload/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UrReturnHelper ReturnValue(propSize, pPropValue, pPropSizeRet);

ol_device_info_t olInfo;
bool isVec3{false};
switch (propName) {
case UR_DEVICE_INFO_NAME:
olInfo = OL_DEVICE_INFO_NAME;
Expand Down Expand Up @@ -76,6 +77,10 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
return ReturnValue(uint32_t{1});
case UR_DEVICE_INFO_MAX_WORK_ITEM_DIMENSIONS:
return ReturnValue(uint32_t{3});
case UR_DEVICE_INFO_MAX_WORK_ITEM_SIZES:
olInfo = OL_DEVICE_INFO_MAX_WORK_GROUP_SIZE;
isVec3 = true;
break;
// Unimplemented features
case UR_DEVICE_INFO_PROGRAM_SET_SPECIALIZATION_CONSTANTS:
case UR_DEVICE_INFO_GLOBAL_VARIABLE_SUPPORT:
Expand All @@ -93,6 +98,26 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION;
}

// OL dimensions are uint32_t while UR is size_t, so they need to be mapped
if (isVec3) {
if (pPropSizeRet) {
*pPropSizeRet = sizeof(size_t) * 3;
}

if (pPropValue) {
ol_dimensions_t olVec;
size_t *urVec = reinterpret_cast<size_t *>(pPropValue);
OL_RETURN_ON_ERR(olGetDeviceInfo(hDevice->OffloadDevice, olInfo,
sizeof(olVec), &olVec));

urVec[0] = olVec.x;
urVec[1] = olVec.y;
urVec[2] = olVec.z;
}

return UR_RESULT_SUCCESS;
}

if (pPropSizeRet) {
OL_RETURN_ON_ERR(
olGetDeviceInfoSize(hDevice->OffloadDevice, olInfo, pPropSizeRet));
Expand Down