Skip to content

[Benchmarks] Remove stdout field from results #19282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

[Benchmarks] Remove stdout field from results #19282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion devops/scripts/benchmarks/benches/benchdnn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ def run(self, env_vars):
unit="ms",
command=command,
env=env_vars,
stdout=output,
git_url=self.suite.git_url(),
git_hash=self.suite.git_tag(),
)
Expand Down
1 change: 0 additions & 1 deletion devops/scripts/benchmarks/benches/compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ def run(self, env_vars) -> list[Result]:
stddev=stddev,
command=command,
env=env_vars,
stdout=result,
unit=parse_unit_type(unit),
git_url=self.bench.git_url(),
git_hash=self.bench.git_hash(),
Expand Down
2 changes: 0 additions & 2 deletions devops/scripts/benchmarks/benches/gromacs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@


class GromacsBench(Suite):

def git_url(self):
return "https://gitlab.com/gromacs/gromacs.git"

Expand Down Expand Up @@ -221,7 +220,6 @@ def run(self, env_vars):
unit="s",
command=command,
env=env_vars,
stdout=mdrun_output,
git_url=self.suite.git_url(),
git_hash=self.suite.git_tag(),
)
Expand Down
1 change: 0 additions & 1 deletion devops/scripts/benchmarks/benches/llamacpp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ def run(self, env_vars) -> list[Result]:
value=mean,
command=command,
env=env_vars,
stdout=result,
unit="token/s",
git_url=self.bench.git_url(),
git_hash=self.bench.git_hash(),
Expand Down
1 change: 0 additions & 1 deletion devops/scripts/benchmarks/benches/syclbench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ def run(self, env_vars) -> list[Result]:
passed=(row[1] == "PASS"),
command=command,
env=env_vars,
stdout=row,
unit="ms",
git_url=self.bench.git_url(),
git_hash=self.bench.git_hash(),
Expand Down
1 change: 0 additions & 1 deletion devops/scripts/benchmarks/benches/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def run(self, env_vars) -> list[Result]:
value=random_value,
command=["test", "--arg1", "foo"],
env={"A": "B"},
stdout="no output",
unit="ms",
)
]
Expand Down
1 change: 0 additions & 1 deletion devops/scripts/benchmarks/benches/umf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ def run(self, env_vars) -> list[Result]:
value=value,
command=command,
env=env_vars,
stdout=result,
unit=self.get_unit_time_or_overhead(explicit_group),
)
)
Expand Down
1 change: 0 additions & 1 deletion devops/scripts/benchmarks/benches/velocity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ def run(self, env_vars) -> list[Result]:
value=self.parse_output(result),
command=command,
env=env_vars,
stdout=result,
unit=self.unit,
git_url=self.vb.git_url(),
git_hash=self.vb.git_hash(),
Expand Down
5 changes: 2 additions & 3 deletions devops/scripts/benchmarks/utils/result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class Result:
value: float
command: list[str]
env: dict[str, str]
stdout: str
passed: bool = True
unit: str = ""
# stddev can be optionally set by the benchmark,
Expand All @@ -36,8 +35,8 @@ class BenchmarkRun:
name: str = "This PR"
hostname: str = "Unknown"
git_hash: str = ""
github_repo: str = None
date: datetime = field(
github_repo: str = ""
date: datetime | None = field(
default=None,
metadata=config(encoder=datetime.isoformat, decoder=datetime.fromisoformat),
)
Expand Down