-
Notifications
You must be signed in to change notification settings - Fork 790
[CI] Add a container for release builds #19289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
Our public releases should satisfy these requirements - https://vfxplatform.com Among them - glibc 2.28. The best way to achieve it - is to use ASWF images, which already have the required env. I've created a container based on aswf/ci-base:2025.1. The original image already contains CUDA SDK, but not ROCm. So I've additionally installed it using https://rocm.docs.amd.com/projects/install-on-linux/en/latest/install/quick-start.html for RHEL 8.10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
|
||
# Install ROCm (for RHEL 8.10), see: | ||
# https://rocm.docs.amd.com/projects/install-on-linux/en/latest/install/quick-start.html | ||
RUN dnf -y install https://repo.radeon.com/amdgpu-install/6.4.1/rhel/8.10/amdgpu-install-6.4.60401-1.el8.noarch.rpm && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aswf/ci-bas
is RHEL? Couldn't easily find out by googling it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -13,7 +13,10 @@ USER_ID=1001 | |||
groupadd -g $USER_ID $USER_NAME && useradd $USER_NAME -u $USER_ID -g $USER_ID -m -s /bin/bash | |||
# Add user to video/irc groups so that it can access GPU | |||
usermod -aG video $USER_NAME | |||
usermod -aG irc $USER_NAME | |||
# Not all OS have irc group | |||
if grep -qi 'ubuntu' /etc/os-release; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we instead grep /etc/group
for irc
? Slightly more robust than an OS check
Our public releases should satisfy these requirements - https://vfxplatform.com Among them - glibc 2.28. The best way to achieve it - is to use ASWF images, which already have the required env.
I've created a container based on aswf/ci-base:2025.1. The original image already contains CUDA SDK, but not ROCm. So I've additionally installed it using https://rocm.docs.amd.com/projects/install-on-linux/en/latest/install/quick-start.html for RHEL 8.10.