[SYCL] Bring back RTC support for AMD and Nvidia GPU targets #19342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntel#18918)" (intel#19304)" This reverts commit 29e7b63.
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
jopperm
changed the title
jopperm
commented
Jul 14, 2025
Comment on lines
+669
to
+670
| SmallVector<ToolChain::BitCodeLibraryInfo, 12> CommonDeviceLibs = | ||
| OffloadTC->getDeviceLibs(CPUArgList, Action::OffloadKind::OFK_SYCL); |
There was a problem hiding this comment.
Note to reviewers: This (and the setup of the clang::Driver instance above) is the new bit in this PR. We cannot use CudaToolChain and ROCMToolChain directly because they are marked as hidden symbols.
sommerlukas
approved these changes
Jul 14, 2025
jchlanda
approved these changes
Jul 15, 2025
steffenlarsen
approved these changes
Jul 15, 2025
Signed-off-by: Julian Oppermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back #18918 and #19302, and fixes the issue with shared library builds.
The problem was that we accessed hidden symbols defined in headers from the
clang/libdirectory to obtain paths to the vendor-specific device library files. We now use theToolChain::getDeviceLibsAPI, and supply a minimal implementation for theCudaToolchain.