[SYCL] Enable user-defined sub-group reductions #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restricted to TriviallyCopyable types for now. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Pennycook
added
enhancement
Signed-off-by: John Pennycook <[email protected]>
Original test looked for cl_khr_subgroups, which does not provide shuffles. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
againull
approved these changes
Jul 17, 2020
AlexeySachkov
approved these changes
Jul 27, 2020
jsji
pushed a commit
that referenced
this pull request
Aug 11, 2023
Also fix 'unused variable' warning. Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@b0142af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricted to TriviallyCopyable types for now.
Signed-off-by: John Pennycook [email protected]
This is a partial implementation of the functionality proposed by @psteinbrecher in #1947, enabling custom sub-group reductions for trivially copyable types. I cannot see any good way to implement user-defined reductions using
groupinstead ofsub_grouptoday, or to extend support for arbitrary types, but this is a step in the right direction.Enabling the other algorithms for user-defined types and operators (with the same trivially copyable restriction) could follow the same approach. Starting with reductions in this PR because they are the most common request.