[SYCL][NFC] Increase test coverage for inline asm feature #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadeeval
force-pushed
the
private/fadeeval/Improve_test_coverage_for_inline_asm_feature
branch
2 times, most recently
from
a6ba188 to
73874ae
Compare
fadeeval
force-pushed
the
private/fadeeval/Improve_test_coverage_for_inline_asm_feature
branch
2 times, most recently
from
7320741 to
54b9173
Compare
fadeeval
force-pushed
the
private/fadeeval/Improve_test_coverage_for_inline_asm_feature
branch
2 times, most recently
from
24bd023 to
e99570a
Compare
sycl/test/inline-asm/asm_if.cpp
Outdated
| cgh.parallel_for<KernelFunctor<T>>( | ||
| cl::sycl::range<1>{this->getOutputBufferSize()}, | ||
| [=](cl::sycl::id<1> wiID) [[cl::intel_reqd_sub_group_size(8)]] { | ||
| bool switch_field = false; |
There was a problem hiding this comment.
Suggested change
| bool switch_field = false; | |
| bool SwitchField = false; |
There was a problem hiding this comment.
Can we make this variable a kernel argument? Otherwise, it is too easy for compiler to optimize everything to just one single store, I guess
alexbatashev
changed the title
|
I don't like the format offered by clang-format in one position, so that the clang-format-check does not pass. |
You can wrap this place in |
Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: Aleksander Fadeev <[email protected]>
Add following tests: inline asm for one branch of if inline asm for loop two tests of inline asm for big block of code Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: Aleksander Fadeev <[email protected]>
Signed-off-by: Aleksander Fadeev <[email protected]>
fadeeval
force-pushed
the
private/fadeeval/Improve_test_coverage_for_inline_asm_feature
branch
from
7397a24 to
d776183
Compare
Signed-off-by: Aleksander Fadeev <[email protected]>
|
Please squash the commits and fix the typo in the commit message |
I think, @bader can squash commits from GitHub GUI and use PR description as a commit message, which is kinda what he always does. There's no need to squash the commits manually, restart tests and waste CPU cycles. |
jsji
pushed a commit
that referenced
this pull request
Aug 21, 2023
jsji
pushed a commit
that referenced
this pull request
Aug 31, 2023
jsji
pushed a commit
that referenced
this pull request
Jan 4, 2024
…" (#2276) Per discussion in Khronos and the spec itself, OpMatrixTimesScalar should not be used in OpenCL environment, as long as the same can be achieved either via an elementwise multiplication with a cooperative matrix object created from the scalar using OpConstantComposite or by iterating over the elements of the cooperative matrix to multiply each element by the scalar. Spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_cooperative_matrix.asciidoc This reverts commit 6522c4ac4764cc1f251edd4266d06cba64549928. Original commit: KhronosGroup/SPIRV-LLVM-Translator@3b6ff3e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds inline_asm feature tests with branching and loop.
Signed-off-by: Aleksander Fadeev [email protected]