[SYCL] Visit explicit dependencies during finished command cleanup #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look at the test failures |
rbegam
reviewed
Aug 11, 2020
Previously, only implicit dependencies (represented by DepDesc) of each command node were visited during finished command cleanup. That meant that command nodes with no implicit dependencies were never cleaned up unless waited for directly (via queue::wait or event::wait on that event). This patch changes graph traversal during cleanup, so that all command dependencies are visited, whether represented by DepDesc or not. Signed-off-by: Sergey Semenov <[email protected]>
sergey-semenov
force-pushed
the
handleunwaitedcase
branch
from
a0c6a8f to
ad9449a
Compare
sergey-semenov
changed the title
|
Sorry for the delay. I ended up switching to a different solution due to issues when cleaning up commands during graph builder destruction. @rbegam please, take a look. |
|
An alternate solution would be to kill off command nodes without explicit dependencies after their enqueuing. That would address more problematic cases than this change alone. Moving this PR to draft for now. |
|
It looks like now you have accumulated some experience about this foggy unexplored part of the SYCL specification. |
|
Superseded by #2492 |
jsji
pushed a commit
that referenced
this pull request
Jan 4, 2024
…2265) ImageOpMask pointer was passed to closure as reference. Closure is executed outside of original stack frame which renders reference invalid. Fixes some ASan errors from issue #2233. Original commit: KhronosGroup/SPIRV-LLVM-Translator@29d4cd3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only implicit dependencies (represented by DepDesc) of each
command node were visited during finished command cleanup. That meant
that command nodes with no implicit dependencies were never cleaned up
unless waited for directly (via queue::wait or event::wait on that
event). This patch changes graph traversal during cleanup, so that all
command dependencies are visited, whether represented by DepDesc or not.
Signed-off-by: Sergey Semenov [email protected]