[SYCL] Fix race that occurs when using sampler in parallel #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Flegontov <[email protected]>
Signed-off-by: Alexander Flegontov <[email protected]>
rbegam
reviewed
Aug 11, 2020
@rbegam, No, I think since this is a sporadic issue and we already have a test suit to check this thread safety issue. |
rbegam
approved these changes
Aug 12, 2020
jsji
pushed a commit
that referenced
this pull request
Jan 11, 2024
…obal variable declarations (#2267) Global variable declarations are not permitted to have no address space or addrspace(0). This PR is to document this contract. Original commit: KhronosGroup/SPIRV-LLVM-Translator@e66cfea
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Update link for updating UNIFIED_RUNTIME_TAG in contribution doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes sporadic hangs caused by data race in m_contextToSampler(MContextToSampler) variable of the sampler_impl class. Adding new elements into this shared map from different threads led to a race.
Signed-off-by: Alexander Flegontov [email protected]